bug in models\guestbook.php

Phoca Guestbook - creating guestbooks in Joomla! CMS
tomash21
Phoca Newbie
Phoca Newbie
Posts: 2
Joined: 27 Aug 2015, 12:57

bug in models\guestbook.php

Post by tomash21 »

Hello.
Seems like you have a bug in SiteName\components\com_phocaguestbook\models\guestbook.php

On line 305:
$order = $params->get('items_order', 'ordering');
But!
There are not `items_order` parameter in params but there is `items_orderby`!!!!!
check SiteName\components\com_phocaguestbook\views\guestbook\tmpl\default.xml
So it should be:
$order = $params->get('items_orderby', 'ordering');

That's why ordering doesn't work, when you change parameter in menu settings. After this fix everything works fine!
User avatar
Jan
Phoca Hero
Phoca Hero
Posts: 48535
Joined: 10 Nov 2007, 18:23
Location: Czech Republic
Contact:

Re: bug in models\guestbook.php

Post by Jan »

Hi, thank you very much for the info, this will be fixed in next version.

Thank you, Jan
If you find Phoca extensions useful, please support the project
User avatar
Jan
Phoca Hero
Phoca Hero
Posts: 48535
Joined: 10 Nov 2007, 18:23
Location: Czech Republic
Contact:

Re: bug in models\guestbook.php

Post by Jan »

Hi, should be OK in version 3.0.7

https://www.phoca.cz/news/963-phoca-gue ... 7-released

Jan
If you find Phoca extensions useful, please support the project
Post Reply