some ampersands missed in code

[Hoffi]

While removing ampersands you also made twins to singles by removing one from "&&" in "if" statements - now there are "binary and"s instead of "logical and"s - a totally different thing causing curious phenomena I fear.

Found e.g. in Phoca Download 3.0.5 site/views/play/tmpl/default.php(14) - but there are much more.

Also you should remove the assignments in (admin) controller.php(53) where parent::display() is called. In line 52 on function definition it's ok as default param, but not in a function call. (same found in Phoca Maps 3.0.1).

Best regards,
Hoffi

[Jan]

Hi, thank you very much for the info, yes this seems to be a typo error. If you know other places, please let me know.

I will fix it in next releases.

parent:display() - yes, this is known issue, I have found it in one of the component so in my todo is to remove it for all others.

Thank you very much for this useful information, Jan

[Hoffi]

site\views\categories\view.html.php(112)
site\views\categories\tmpl\default.php(139)
site\views\category\view.html.php(264)
site\views\category\tmpl\default_files.php(206)
site\views\download\view.html.php(73, 209)
site\views\download\tmpl\default.php(8, 72)
site\views\file\view.html.php(212)
site\views\file\tmpl\default.php(12)

I hope I found all.

[Jan]

Great, thank you very much.

Jan

[Jan]

Hi, thank you very much for the info. Set in version 3.0.6

Jan