Page 1 of 1

Inconsistencies in several phocadownloadlink views

Posted: 02 Mar 2015, 11:29
by mperaya
As you may have noticed, there are many incosistencies in several phocadownloadlink views, on admin backend and frontend.

In many view.html.php files the vars are stored on a $this->t array and then, on the default.php file of the view the vars are retrieved from an inexistent $this->tmpl array, or viceversa: the vars are stored on $tmpl and assigned to template and then the default.php file still tries to retrieve their value from $this->t.

This makes thinks broken when you want to select a file and insert the phocadownload tag on backend. (at least at 3.0.6 component version on joomla 3.4)

If you want, here you have a diff file from a fresh 3.0.6 component and a modified one that is changed to correct this issue. All references are stored on $tmpl in view.html.php file and assigned to template and then retrieved from $this->tmpl on the default.php file of the view.

http://ender.escila.es/com_phocadownload_v3.0.6.diff

Hope this helps.

Re: Inconsistencies in several phocadownloadlink views

Posted: 03 Mar 2015, 13:19
by Jan
Hi, thank you very much, yes, some of the code were not change when upgrading from $tmpl to $this->t variable.

Thank you very much, I will set it in next release.

Jan